Skip to content

Commit

Permalink
Resolve FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
slowli committed Nov 12, 2024
1 parent e8ba52e commit 4b1f757
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion core/lib/contract_verifier/src/compilers/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ fn parse_standard_json_output(
.iter()
.any(|err| err["severity"].as_str() == Some("error"))
{
// FIXME: collected messages contain warnings as well; is this intentional?
let error_messages = errors
.into_iter()
.filter_map(|err| {
Expand Down
1 change: 0 additions & 1 deletion core/lib/contract_verifier/src/compilers/vyper.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ impl VyperInput {
file_name,
sources,
optimizer_mode: if req.optimization_used {
// FIXME: values have differing semantics compared to other compilers; is this OK?
req.optimizer_mode
} else {
// `none` mode is not the default mode (which is `gas`), so we must specify it explicitly here
Expand Down
2 changes: 2 additions & 0 deletions core/lib/types/src/contract_verification_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ pub struct VerificationIncomingRequest {
#[serde(flatten)]
pub compiler_versions: CompilerVersions,
pub optimization_used: bool,
/// Optimization mode used for the contract. Semantics depends on the compiler used; e.g., for `vyper`,
/// allowed values are `gas` (default), `codesize` or `none`.
pub optimizer_mode: Option<String>,
#[serde(default)]
pub constructor_arguments: Bytes,
Expand Down

0 comments on commit 4b1f757

Please sign in to comment.