Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix null protocol version error #2094

Merged
merged 2 commits into from
May 30, 2024

Conversation

Artemka374
Copy link
Contributor

@Artemka374 Artemka374 commented May 30, 2024

What ❔

Don't return results with NULL protocol version from DB.

Why ❔

It's incorrect

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@Artemka374 Artemka374 enabled auto-merge May 30, 2024 10:06
@Artemka374 Artemka374 added this pull request to the merge queue May 30, 2024
Merged via the queue into main with commit aab3a7f May 30, 2024
27 checks passed
@Artemka374 Artemka374 deleted the afo/fix-null-protocol-version-error branch May 30, 2024 10:36
github-merge-queue bot pushed a commit that referenced this pull request May 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[14.4.0](prover-v14.3.0...prover-v14.4.0)
(2024-05-30)


### Features

* Make house keeper emit correct protocol version
([#2062](#2062))
([a58a7e8](a58a7e8))
* **pli:** add support for persistent config
([#1907](#1907))
([9d5631c](9d5631c))
* Protocol semantic version
([#2059](#2059))
([3984dcf](3984dcf))
* **prover:** Add `prover_version` binary.
([#2089](#2089))
([e1822f6](e1822f6))


### Bug Fixes

* fix null protocol version error
([#2094](#2094))
([aab3a7f](aab3a7f))
* fix query for proof compressor metrics
([#2103](#2103))
([d23d24e](d23d24e))
* **prover_dal:** fix `save_prover_protocol_version` query
([#2096](#2096))
([d8dd1ae](d8dd1ae))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: perekopskiy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants