feat: Protocol semantic version #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
requested review from
RomanBrodetski,
StanislavBreadless,
Artemka374 and
mm-zk
mm-zk
reviewed
May 28, 2024
core/node/eth_watch/src/event_processors/governance_upgrades.rs
Outdated
Show resolved
Hide resolved
## What ❔ We'll store the semantic version of the protocol in the `common.json`. For the upgrade itself we'll have to use packed format, but for the l2 transaction we'll use only the `minor` version (for compatibility with the server). It is expected that the upgrade transaction is only present during at least `minor` upgrades and never present during `patch` ones ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`. - [ ] Spellcheck has been run via `zk spellcheck`.
## What ❔ Adjust prover subsystems to take into account patch versions. ## Why ❔ <!-- Why are these changes done? What goal do they contribute to? What are the principles behind them? --> <!-- Example: PR templates ensure PR reviewers, observers, and future iterators are in context about the evolution of repos. --> ## Checklist <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`.
mm-zk
previously approved these changes
May 29, 2024
mm-zk
previously approved these changes
May 29, 2024
Artemka374
previously approved these changes
May 30, 2024
perekopskiy
force-pushed
the
sb-semver-for-protocol-version
branch
from
778040e to
70e622b
Compare
Artemka374
previously approved these changes
May 30, 2024
Artemka374
approved these changes
May 30, 2024
This was referenced May 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [24.5.0](core-v24.4.0...core-v24.5.0) (2024-05-30) ### Features * Add protocol_version label to WG jobs metric ([#2009](#2009)) ([e0a3393](e0a3393)) * **config:** remove zksync home ([#2022](#2022)) ([d08fe81](d08fe81)) * **en:** Improve tree snapshot recovery ([#1938](#1938)) ([5bc8234](5bc8234)) * Make house keeper emit correct protocol version ([#2062](#2062)) ([a58a7e8](a58a7e8)) * **node_framework:** Migrate main node to the framework ([#1997](#1997)) ([27a26cb](27a26cb)) * **node_framework:** Synchronize pools layer with logic in initialize_components ([#2079](#2079)) ([3202461](3202461)) * Protocol semantic version ([#2059](#2059)) ([3984dcf](3984dcf)) * **prover:** Adnotate prover queue metrics with protocol version ([#1893](#1893)) ([d1e1004](d1e1004)) * save writes needed for tree in state keeper ([#1965](#1965)) ([471af53](471af53)) * **test:** Add filebased config support for integration tests ([#2043](#2043)) ([be3ded9](be3ded9)) * **vm-runner:** implement VM runner main body ([#1955](#1955)) ([bf5b6c2](bf5b6c2)) ### Bug Fixes * **API:** polish web3 api block-related types ([#1994](#1994)) ([6cd3c53](6cd3c53)) * **en:** chunk factory deps ([#2077](#2077)) ([4b9e6fa](4b9e6fa)) * **en:** Fix recovery-related metrics ([#2014](#2014)) ([86355d6](86355d6)) * **eth-watch:** Do not track for stm, only for diamond proxy ([#2080](#2080)) ([87adac9](87adac9)) * fix metrics reporting wrong values ([#2065](#2065)) ([2ec010a](2ec010a)) * **loadtest:** resolve unit conversion error in loadtest metrics ([#1987](#1987)) ([b5870a0](b5870a0)) * **merkle-tree:** Fix incoherent Merkle tree view ([#2071](#2071)) ([2fc9a6c](2fc9a6c)) * **metadata-calculator:** protective reads sort ([#2087](#2087)) ([160c13c](160c13c)) * **node_framework:** Fix the connection pool size for the catchup task ([#2046](#2046)) ([c00a2eb](c00a2eb)) * **node_framework:** Use custom pool for commitiment generator ([#2076](#2076)) ([994df8f](994df8f)) * **protocol_version:** Add backward compatibility ([#2097](#2097)) ([391624b](391624b)) * **pruning:** Fix DB pruner responsiveness during shutdown ([#2058](#2058)) ([0a07312](0a07312)) * **zk_toolbox:** Use both folders for loading contracts ([#2030](#2030)) ([97c6d5c](97c6d5c)) ### Performance Improvements * **commitment-generator:** Run commitment generation for multiple batches in parallel ([#1984](#1984)) ([602bf67](602bf67)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 30, 2024
🤖 I have created a release *beep* *boop* --- ## [14.4.0](prover-v14.3.0...prover-v14.4.0) (2024-05-30) ### Features * Make house keeper emit correct protocol version ([#2062](#2062)) ([a58a7e8](a58a7e8)) * **pli:** add support for persistent config ([#1907](#1907)) ([9d5631c](9d5631c)) * Protocol semantic version ([#2059](#2059)) ([3984dcf](3984dcf)) * **prover:** Add `prover_version` binary. ([#2089](#2089)) ([e1822f6](e1822f6)) ### Bug Fixes * fix null protocol version error ([#2094](#2094)) ([aab3a7f](aab3a7f)) * fix query for proof compressor metrics ([#2103](#2103)) ([d23d24e](d23d24e)) * **prover_dal:** fix `save_prover_protocol_version` query ([#2096](#2096)) ([d8dd1ae](d8dd1ae)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: perekopskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds support for protocol semantic versions. Major version is always 0. Minor version has the same meaning as the previous concept of protocol version we used. Patch version can be bumped only for vks upgrades.
Adds new DB table
protocol_vk_patchesthat keeps track of patch versions.protocol_vk_patchesWhy ❔
It makes it possible to upgrade vks without bumping minor part of protocol version.
Checklist
zk fmtandzk lint.zk spellcheck.Part of EVM-648