Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validium mode abstraction #1015

Closed
wants to merge 75 commits into from
Closed

feat: Validium mode abstraction #1015

Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
f6c99ac
Add Validium mode example
ilitteri Jan 25, 2024
9736d97
Use Ethereum's L1 gas price
ilitteri Jan 25, 2024
2d9c427
Add --validium-mode flag to zk init command
ilitteri Jan 25, 2024
24cd669
Do not construct the pubdata in Validium mode
ilitteri Jan 25, 2024
af06969
Do not charge for pubdata in Validium mode
ilitteri Jan 25, 2024
982d638
- add basic abstraction for DataProvider for eth_tx_aggregator
mationorato Jan 26, 2024
d9548c8
run zk fmt
mationorato Jan 26, 2024
bf32093
revert yarn.lock (#77)
toni-calvin Jan 29, 2024
90e06d7
Add l1_batch_committer module
ilitteri Jan 30, 2024
b6ba50c
Remove l1_commit_data, l1_commit_data_size and construct_pubdata meth…
ilitteri Jan 30, 2024
7f6d849
Move construct_pubdata to utils
ilitteri Jan 30, 2024
3c714b9
Commit each batch through a struct that implements the L1BatchCommitt…
ilitteri Jan 30, 2024
748fb83
Remove old data_provider module
ilitteri Jan 30, 2024
6467073
Add l1_batch_committer field to Aggregator struct for later L1BatchCo…
ilitteri Jan 30, 2024
5abeb45
Add l1_batch_committer as a L1BatchPublishCriterion::last_l1_batch_to…
ilitteri Jan 30, 2024
d8027bf
Revert EthTxAggregator changes as they're not needed anymore
ilitteri Jan 30, 2024
bb3c7d1
Fix eth_sender tests
ilitteri Jan 30, 2024
7f9ad63
Update consistency_checker module where needed for using L1BatchCommi…
ilitteri Jan 30, 2024
fc2245f
Update external_node module where needed for using L1BatchCommitter::…
ilitteri Jan 30, 2024
ed898c1
Initialize the Aggregator with a struct that implements L1BatchCommit…
ilitteri Jan 30, 2024
b048893
Remove unnecessary if in construct_pubdata
ilitteri Jan 30, 2024
6ca23ca
Refactor L1BatchCommitter::l1_commit_data implementations
ilitteri Jan 30, 2024
908097d
Save VALIDIUM_MODE env in dev.env
ilitteri Jan 30, 2024
dedcf24
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
ilitteri Jan 30, 2024
6009297
Update contracts submodule commit
ilitteri Jan 31, 2024
80d4b03
Update contracts submodule commit
ilitteri Jan 31, 2024
b791161
Fix init.ts
ilitteri Jan 31, 2024
b4821e1
feat: Rename Validium abstraction and implementors (#92)
ilitteri Feb 2, 2024
6d08fc4
feat: Not charging for pubdata (#98)
ColoCarletti Feb 2, 2024
6f9ac9c
Remove debug prints
ilitteri Feb 2, 2024
0f4cffe
Add tracing::debug logs
ilitteri Feb 2, 2024
e34dcfa
Merge branch 'main' of github.com:lambdaclass/zksync-era into validiu…
ilitteri Feb 2, 2024
5ec41b2
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
ilitteri Feb 2, 2024
0ce5616
Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…
ilitteri Feb 3, 2024
ebca913
Reintroduce L1BatchCommitDataGenerator trait
ilitteri Feb 3, 2024
6f9eb9f
Remove unused trait method
ilitteri Feb 3, 2024
c7bd24a
add l1_gas_per_pubdata_byte to config generator (#103)
ColoCarletti Feb 7, 2024
e75d4eb
fix: Delete unused config files in validium pubdata abstraction (#113)
toni-calvin Feb 8, 2024
f5222a6
Merge branch 'validium_mode_new_fee_model_final' of github.com:lambda…
ilitteri Feb 8, 2024
f7df89e
apply spellcheck
mationorato Feb 9, 2024
f8f5283
update contracts submodule
mationorato Feb 9, 2024
584b4c9
update contracts submodule
mationorato Feb 9, 2024
83df096
fix: exclude validium_mode_example from .dockerignore (#122)
Oppen Feb 9, 2024
706bc44
remove println debugging left behind
lferrigno Feb 9, 2024
855c727
Added new words for spellchecking
lferrigno Feb 9, 2024
6327106
Merge branch 'feat_validium_pubdata_abstraction' of github.com:lambda…
lferrigno Feb 9, 2024
eae85d1
fmt fix
lferrigno Feb 14, 2024
502f3e8
fix: protobuf and lint fixes (#125)
Oppen Feb 14, 2024
c4de515
fix core linter
lferrigno Feb 14, 2024
73a82a2
Fix state_keeper_from_env test
ilitteri Feb 14, 2024
12ba1b7
Fix eth_sender from_env test
ilitteri Feb 14, 2024
85ca136
Remove debug config
ilitteri Feb 14, 2024
d31d1a6
feat: adapt `consistency_checker` tests for running both in Validium …
jordibonet-lambdaclass Feb 15, 2024
b693293
fix: update function visibility in `consistency_checker` tests (#137)
jordibonet-lambdaclass Feb 15, 2024
bdb26c3
feat: `--validium-mode` flag sets Validium config automatically (#138)
ilitteri Feb 15, 2024
916c56b
zk fmt
ilitteri Feb 15, 2024
7391c21
Fix protobuf unit tests
ilitteri Feb 15, 2024
9694281
Fix protobuf tests and update TODO comments
ilitteri Feb 15, 2024
7cd2be9
Rollback Rollup config (as default)
ilitteri Feb 15, 2024
d38dc48
zk lint
ilitteri Feb 15, 2024
fc03061
feat: adapt `eth_sender` tests for running both in Validium mode and …
toni-calvin Feb 15, 2024
08fa235
feat: adapt `zksync_env_config::eth_sender` tests for running both in…
toni-calvin Feb 16, 2024
d3fa3b4
feat: adapt `zksync_env_config::chain` tests for running both in Vali…
jordibonet-lambdaclass Feb 16, 2024
34f9f37
Refactor L1BatchCommitDataGeneratorMode Default implementation
ilitteri Feb 16, 2024
776f935
move l1_batch_commit_data_generator to DataSizeCriterion so that it d…
ilitteri Feb 19, 2024
7f52a8d
add parameters to the ConsistencyChecker structure itself, rather tha…
ilitteri Feb 19, 2024
95c08a5
Merge branch 'main' of github.com:lambdaclass/zksync-era into feat_va…
ilitteri Feb 19, 2024
9a26760
Revert "Merge branch 'main' of github.com:lambdaclass/zksync-era into…
ilitteri Feb 19, 2024
3028625
Move construct_pubdata method from utils to L1BatchWithMetadata (#153)
toni-calvin Feb 19, 2024
b07dc55
Merge main
ilitteri Feb 19, 2024
c930b54
Merge branch 'validium_mode_new_fee_model_final' of github.com:Lambda…
ilitteri Feb 19, 2024
82efd79
Remove validium_mode_example crate (#161)
ilitteri Feb 21, 2024
c4b6cde
Remove TODOs comments
jorbush Feb 23, 2024
0a5407e
Revert "Remove TODOs comments"
jorbush Feb 23, 2024
ec0af17
Fix: pubdata in Validium mode should be an empty array
ilitteri Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ keys/setup
!backups/
!core/
!prover/
!validium_mode_example/
!yarn.lock
!package.json
!Cargo.lock
Expand Down
3 changes: 2 additions & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[submodule "contracts"]
path = contracts
url = https://github.com/matter-labs/era-contracts.git
url = https://github.com/LambdaClass/era-contracts.git
branch = update_validium_mode_contracts
Loading
Loading