Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(test): wait for server in upgrade test #1784

Merged
merged 4 commits into from
Apr 24, 2024
Merged

chore(test): wait for server in upgrade test #1784

merged 4 commits into from
Apr 24, 2024

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Apr 24, 2024 •
edited
Loading

What ❔

  • Waits more for server to start in upgrade test.
  • Fixes typo in core/lib/zksync_core/Cargo.toml

Why ❔

Test is flaky in its current form

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@perekopskiy perekopskiy requested a review from Raid5594 April 24, 2024 07:21
@perekopskiy perekopskiy enabled auto-merge April 24, 2024 09:28
@perekopskiy perekopskiy added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@perekopskiy perekopskiy enabled auto-merge April 24, 2024 11:32
@perekopskiy perekopskiy added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@perekopskiy perekopskiy added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit df54516 Apr 24, 2024
35 of 36 checks passed
@perekopskiy perekopskiy deleted the upgrade-test-proper-wait branch April 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@Raid5594 Raid5594 Awaiting requested review from Raid5594

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perekopskiy @StanislavBreadless