Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add foundry installation to zk-environment Dockerfile #1995

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: add foundry installation to zk-environment Dockerfile #1995

merged 1 commit into from
May 20, 2024

Conversation

aon
Copy link
Contributor

@aon aon commented May 20, 2024

What ❔

  • Adds foundry installation to zk-environment Dockerfile

Why ❔

  • This is necessary for adding CI to zk_toolbox

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@aon aon requested a review from Deniallugo May 20, 2024 20:25
@Deniallugo Deniallugo added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit e55b11f May 20, 2024
24 of 26 checks passed
@Deniallugo Deniallugo deleted the aon-add-foundry-to-dockerfile branch May 20, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deniallugo Deniallugo Deniallugo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aon @Deniallugo