Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added debug_proof to prover_cli #2052

Merged
merged 7 commits into from
Jun 5, 2024
Merged

feat: added debug_proof to prover_cli #2052

merged 7 commits into from
Jun 5, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented May 24, 2024

What ❔

  • Prover_cli has a new command - debug-proof, that prints a lot more detailed information about any basic proof file.

Why ❔

  • This will speed up debugging of the failed proofs.
  • Small caveat - the cli has to be compiled with verbose_circuits feature - which will include the whole zkevm_test_harness and all the other crypto libraries.

How to use:

  • Simply download the .bin file with the proof, and run ./prover_cli debug-proof file.bin

Part of EVM-639

@mm-zk mm-zk requested review from ilitteri and Artemka374 May 24, 2024 17:59
ilitteri
ilitteri previously approved these changes May 24, 2024
Copy link
Contributor

@ilitteri ilitteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's just a missing new line at the end of file in prover/prover_cli/Cargo.toml.

@mm-zk mm-zk requested a review from ilitteri May 27, 2024 09:20
@mm-zk mm-zk requested review from RomanBrodetski and EmilLuta June 5, 2024 10:14
@mm-zk mm-zk added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit b1ad01b Jun 5, 2024
27 checks passed
@mm-zk mm-zk deleted the mmzk_0524_better_tool branch June 5, 2024 11:14
github-merge-queue bot pushed a commit that referenced this pull request Jun 14, 2024
🤖 I have created a release *beep* *boop*
---


##
[15.0.0](prover-v14.5.0...prover-v15.0.0)
(2024-06-14)


### ⚠ BREAKING CHANGES

* updated boojum and nightly rust compiler
([#2126](#2126))

### Features

* added debug_proof to prover_cli
([#2052](#2052))
([b1ad01b](b1ad01b))
* faster & cleaner VK generation
([#2084](#2084))
([89c8cac](89c8cac))
* **node:** Move some stuff around
([#2151](#2151))
([bad5a6c](bad5a6c))
* **object-store:** Allow caching object store objects locally
([#2153](#2153))
([6c6e65c](6c6e65c))
* **proof_data_handler:** add new endpoints to the TEE prover interface
API ([#1993](#1993))
([eca98cc](eca98cc))
* **prover:** Add file based config for fri prover gateway
([#2150](#2150))
([81ffc6a](81ffc6a))
* **prover:** file based configs for witness generator
([#2161](#2161))
([24b8f93](24b8f93))
* support debugging of recursive circuits in prover_cli
([#2217](#2217))
([7d2e12d](7d2e12d))
* updated boojum and nightly rust compiler
([#2126](#2126))
([9e39f13](9e39f13))
* verification of L1Batch witness (BFT-471) - attempt 2
([#2232](#2232))
([dbcf3c6](dbcf3c6))
* verification of L1Batch witness (BFT-471)
([#2019](#2019))
([6cc5455](6cc5455))


### Bug Fixes

* **config:** Split object stores
([#2187](#2187))
([9bcdabc](9bcdabc))
* **prover_cli:** Fix delete command
([#2119](#2119))
([214f981](214f981))
* **prover_cli:** Fix the issues with `home` path
([#2104](#2104))
([1e18af2](1e18af2))
* **prover:** config
([#2165](#2165))
([e5daf8e](e5daf8e))
* **prover:** Disallow state changes from successful
([#2233](#2233))
([2488a76](2488a76))
* Treat 502s and 503s as transient for GCS OS
([#2202](#2202))
([0a12c52](0a12c52))


### Reverts

* verification of L1Batch witness (BFT-471)
([#2230](#2230))
([227e101](227e101))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants