Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prover_cli): Fix Minor Bugs in Prover CLI #2264

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix(prover_cli): Fix Minor Bugs in Prover CLI #2264

merged 3 commits into from
Jun 19, 2024

Conversation

ColoCarletti
Copy link
Contributor

This PR fixes bugs in the Prover CLI:

  • The status command was not displaying correctly for more than one batch.
  • The witness job status was incorrectly set to "in progress" when some batches were in the queue and others were waiting for proofs.
  • The config command failed if there was no configuration file. Now, it creates one if it’s not found.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

@ColoCarletti ColoCarletti changed the title fix(prover_cli): Fix prover cli minor bugs fix(prover_cli): Fix Minor Bugs in Prover CLI Jun 18, 2024
@EmilLuta EmilLuta added this pull request to the merge queue Jun 19, 2024
Merged via the queue into main with commit 440f2a7 Jun 19, 2024
28 checks passed
@EmilLuta EmilLuta deleted the fix_prover_cli_minor_bugs branch June 19, 2024 13:25
@zksync-era-bot zksync-era-bot mentioned this pull request Jun 19, 2024
Merged
gabrieldemian pushed a commit to vianetwork/via-server that referenced this pull request Jun 21, 2024
@ColoCarletti @gabrieldemian
fix(prover_cli): Fix Minor Bugs in Prover CLI (matter-labs#2264)
d0b8c0e 
This PR fixes bugs in the Prover CLI:
- The status command was not displaying correctly for more than one
batch.
- The witness job status was incorrectly set to "in progress" when some
batches were in the queue and others were waiting for proofs.
- The config command failed if there was no configuration file. Now, it
creates one if it’s not found.


## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [x] Code has been formatted via `zk fmt` and `zk lint`.
- [x] Spellcheck has been run via `zk spellcheck`.
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
@zksync-era-bot
chore(main): release prover 15.1.0 (#2261)
a33c80c 
🤖 I have created a release *beep* *boop*
---


##
[15.1.0](prover-v15.0.0...prover-v15.1.0)
(2024-07-10)


### Features

* **api:** Retry `read_value`
([#2352](#2352))
([256a43c](256a43c))
* Base Token Fundamentals
([#2204](#2204))
([39709f5](39709f5))
* BWIP ([#2258](#2258))
([75bdfcc](75bdfcc))
* change `zkSync` occurences to `ZKsync`
([#2227](#2227))
([0b4104d](0b4104d))
* **config:** Make getaway_url optional
([#2412](#2412))
([200bc82](200bc82))
* consensus support for pruning (BFT-473)
([#2334](#2334))
([abc4256](abc4256))
* **contract-verifier:** Add file based config for contract verifier
([#2415](#2415))
([f4410e3](f4410e3))
* **en:** file based configs for en
([#2110](#2110))
([7940fa3](7940fa3))
* Make all core workspace crate names start with zksync_
([#2294](#2294))
([8861f29](8861f29))
* Minimal External API Fetcher
([#2383](#2383))
([9f255c0](9f255c0))
* **prover:** Add file based config for compressor
([#2353](#2353))
([1d6f87d](1d6f87d))
* **prover:** Add file based config for prover fri
([#2184](#2184))
([f851615](f851615))
* **prover:** Add file based config for witness vector generator
([#2337](#2337))
([f86eb13](f86eb13))
* **prover:** Add file based config support for
vk-setup-data-generator-server-fri
([#2371](#2371))
([b0e72c9](b0e72c9))
* **prover:** Add prometheus port to witness generator config
([#2385](#2385))
([d0e1add](d0e1add))
* **prover:** Add prover_cli stats command
([#2362](#2362))
([fe65319](fe65319))
* Remove cached commitments, add BWIP to docs
([#2400](#2400))
([e652e4d](e652e4d))
* Remove initialize_components function
([#2284](#2284))
([0a38891](0a38891))
* snark proof is already verified inside wrap_proof function
([#1903](#1903))
([2c8cf35](2c8cf35))
* Switch to using crates.io deps
([#2409](#2409))
([27fabaf](27fabaf))
* **tee:** TEE Prover Gateway
([#2333](#2333))
([f8df34d](f8df34d))
* upgraded encoding of transactions in consensus Payload.
([#2245](#2245))
([cb6a6c8](cb6a6c8))
* Validium with DA
([#2010](#2010))
([fe03d0e](fe03d0e))
* **zk_toolbox:** Add prover run
([#2272](#2272))
([598ef7b](598ef7b))


### Bug Fixes

* Fix rustls setup for jsonrpsee clients
([#2417](#2417))
([a040f09](a040f09))
* **proof_compressor:** Fix backward compatibility
([#2356](#2356))
([76508c4](76508c4))
* prover Cargo.lock
([#2280](#2280))
([05c6f35](05c6f35))
* **prover_cli:** Fix Minor Bugs in Prover CLI
([#2264](#2264))
([440f2a7](440f2a7))
* **prover_cli:** Remove outdated fix for circuit id in node wg
([#2248](#2248))
([db8e71b](db8e71b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
irnb pushed a commit to vianetwork/via-server that referenced this pull request Jul 12, 2024
@zksync-era-bot @irnb
chore(main): release prover 15.1.0 (matter-labs#2261)
07f2375 
🤖 I have created a release *beep* *boop*
---


##
[15.1.0](matter-labs/zksync-era@prover-v15.0.0...prover-v15.1.0)
(2024-07-10)


### Features

* **api:** Retry `read_value`
([matter-labs#2352](matter-labs#2352))
([256a43c](matter-labs@256a43c))
* Base Token Fundamentals
([matter-labs#2204](matter-labs#2204))
([39709f5](matter-labs@39709f5))
* BWIP ([matter-labs#2258](matter-labs#2258))
([75bdfcc](matter-labs@75bdfcc))
* change `zkSync` occurences to `ZKsync`
([matter-labs#2227](matter-labs#2227))
([0b4104d](matter-labs@0b4104d))
* **config:** Make getaway_url optional
([matter-labs#2412](matter-labs#2412))
([200bc82](matter-labs@200bc82))
* consensus support for pruning (BFT-473)
([matter-labs#2334](matter-labs#2334))
([abc4256](matter-labs@abc4256))
* **contract-verifier:** Add file based config for contract verifier
([matter-labs#2415](matter-labs#2415))
([f4410e3](matter-labs@f4410e3))
* **en:** file based configs for en
([matter-labs#2110](matter-labs#2110))
([7940fa3](matter-labs@7940fa3))
* Make all core workspace crate names start with zksync_
([matter-labs#2294](matter-labs#2294))
([8861f29](matter-labs@8861f29))
* Minimal External API Fetcher
([matter-labs#2383](matter-labs#2383))
([9f255c0](matter-labs@9f255c0))
* **prover:** Add file based config for compressor
([matter-labs#2353](matter-labs#2353))
([1d6f87d](matter-labs@1d6f87d))
* **prover:** Add file based config for prover fri
([matter-labs#2184](matter-labs#2184))
([f851615](matter-labs@f851615))
* **prover:** Add file based config for witness vector generator
([matter-labs#2337](matter-labs#2337))
([f86eb13](matter-labs@f86eb13))
* **prover:** Add file based config support for
vk-setup-data-generator-server-fri
([matter-labs#2371](matter-labs#2371))
([b0e72c9](matter-labs@b0e72c9))
* **prover:** Add prometheus port to witness generator config
([matter-labs#2385](matter-labs#2385))
([d0e1add](matter-labs@d0e1add))
* **prover:** Add prover_cli stats command
([matter-labs#2362](matter-labs#2362))
([fe65319](matter-labs@fe65319))
* Remove cached commitments, add BWIP to docs
([matter-labs#2400](matter-labs#2400))
([e652e4d](matter-labs@e652e4d))
* Remove initialize_components function
([matter-labs#2284](matter-labs#2284))
([0a38891](matter-labs@0a38891))
* snark proof is already verified inside wrap_proof function
([matter-labs#1903](matter-labs#1903))
([2c8cf35](matter-labs@2c8cf35))
* Switch to using crates.io deps
([matter-labs#2409](matter-labs#2409))
([27fabaf](matter-labs@27fabaf))
* **tee:** TEE Prover Gateway
([matter-labs#2333](matter-labs#2333))
([f8df34d](matter-labs@f8df34d))
* upgraded encoding of transactions in consensus Payload.
([matter-labs#2245](matter-labs#2245))
([cb6a6c8](matter-labs@cb6a6c8))
* Validium with DA
([matter-labs#2010](matter-labs#2010))
([fe03d0e](matter-labs@fe03d0e))
* **zk_toolbox:** Add prover run
([matter-labs#2272](matter-labs#2272))
([598ef7b](matter-labs@598ef7b))


### Bug Fixes

* Fix rustls setup for jsonrpsee clients
([matter-labs#2417](matter-labs#2417))
([a040f09](matter-labs@a040f09))
* **proof_compressor:** Fix backward compatibility
([matter-labs#2356](matter-labs#2356))
([76508c4](matter-labs@76508c4))
* prover Cargo.lock
([matter-labs#2280](matter-labs#2280))
([05c6f35](matter-labs@05c6f35))
* **prover_cli:** Fix Minor Bugs in Prover CLI
([matter-labs#2264](matter-labs#2264))
([440f2a7](matter-labs@440f2a7))
* **prover_cli:** Remove outdated fix for circuit id in node wg
([matter-labs#2248](matter-labs#2248))
([db8e71b](matter-labs@db8e71b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

@ilitteri ilitteri Awaiting requested review from ilitteri

@Artemka374 Artemka374 Awaiting requested review from Artemka374

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColoCarletti @EmilLuta