refactor: Implement earliest_batch_number_to_sign (BFT-474) #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
changed the title
11 tasks
aakoshh
force-pushed
the
bft-474-earliest-batch-to-sign
branch
2 times, most recently
from
48f275b to
ab02630
Compare
brunoffranca
approved these changes
Jul 9, 2024
aakoshh
force-pushed
the
bft-474-poll-db-and-sign-batch
branch
from
5f43aff to
ba0d8b2
Compare
aakoshh
force-pushed
the
bft-474-earliest-batch-to-sign
branch
from
ab02630 to
5f76d17
Compare
aakoshh
force-pushed
the
bft-474-poll-db-and-sign-batch
branch
from
ba0d8b2 to
512a789
Compare
aakoshh
force-pushed
the
bft-474-earliest-batch-to-sign
branch
from
5f76d17 to
14ea5d7
Compare
brunoffranca
pushed a commit
to matter-labs/era-consensus
that referenced
this pull request
Jul 9, 2024
## What ❔ Bumps the version to 0.1.0-rc.2 ## Why ❔ So that we can merge matter-labs/zksync-era#2399 and matter-labs/zksync-era#2410
Base automatically changed from
bft-474-poll-db-and-sign-batch
to
bft-474-l1-batch-signing
July 9, 2024 19:28
aakoshh
force-pushed
the
bft-474-earliest-batch-to-sign
branch
from
14ea5d7 to
e584719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Implements matter-labs/era-consensus#150
Removes
unsigned_batch_numbersand addsearliest_batch_number_to_signinstead.The PR also enables
PersistentBatchStore::persisted()now that matter-labs/era-consensus#152 has been merged.Why ❔
With the new signing loop this query runs only once at startup, after which we only query the latest batch number and sign everything new, so it's altogether cheaper.
Checklist
zk fmtandzk lint.