refactor(state-keeper): Use owned VM storage for batch executor #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
changed the title
slowli
force-pushed
the
aov-pla-1004-test-vm-runner-with-multiple-l1-batches
branch
from
47d2a70 to
a5d000e
Compare
slowli
commented
Aug 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
ReadStorageFactoryandBatchExecutor.Why ❔
ReadStorageFactoryandBatchExecutorbecome more composable and work in VM runner with less crutches.Checklist
zk fmtandzk lint.fix(vm-runner): Fix data race in storage loader
test(vm-runner): Test VM runner with multiple L1 batches