Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improve revert integration test #2822

Merged
merged 8 commits into from
Sep 10, 2024
Merged

test: Improve revert integration test #2822

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3bc48ed
Improve revert integration test
slowli Sep 6, 2024
7bbf785
Brush up revert IT
slowli Sep 6, 2024
efdd52b
Brush up node logic some more
slowli Sep 6, 2024
9bb820b
Fix log paths for revert test in CI
slowli Sep 6, 2024
39c605a
Relax batch execution conditions + misc fixes
slowli Sep 6, 2024
53ebc20
Fix env for reverter binary
slowli Sep 6, 2024
537b029
Change runner for toolbox job
slowli Sep 9, 2024
c5033d2
Merge branch 'main' into aov-pla-1028-improve-revert-integration-test
slowli Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/ci-core-reusable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ jobs:

- name: Show revert.log logs
if: always()
run: ci_run cat core/tests/revert-test/revert.log || true
run: ci_run cat logs/revert/default/server.log || true

- name: Show upgrade.log logs
if: always()
Expand Down Expand Up @@ -382,7 +382,11 @@ jobs:

- name: Run revert test
run: |
ENABLE_CONSENSUS=${{ matrix.consensus }} DEPLOYMENT_MODE=${{ matrix.deployment_mode }} PASSED_ENV_VARS="ENABLE_CONSENSUS,DEPLOYMENT_MODE" ci_run zk test i revert-en
ENABLE_CONSENSUS=${{ matrix.consensus }} \
DEPLOYMENT_MODE=${{ matrix.deployment_mode }} \
PASSED_ENV_VARS="ENABLE_CONSENSUS,DEPLOYMENT_MODE" \
ci_run zk test i revert-en

# test terminates the nodes, so we restart them.
if [[ "${{ matrix.deployment_mode }}" == "Rollup" ]]; then
ZKSYNC_ENV=docker ci_run zk server --components=$SERVER_COMPONENTS &>>server.log &
Expand Down Expand Up @@ -414,13 +418,13 @@ jobs:
if: always()
run: ci_run cat ext-node.log || true

- name: Show revert_main.log logs
- name: Show revert logs (main node)
if: always()
run: ci_run cat core/tests/revert-test/revert_main.log || true
run: ci_run cat logs/revert/en/default/server.log || true

- name: Show revert_ext.log logs
- name: Show revert logs (EN)
if: always()
run: ci_run cat core/tests/revert-test/revert_ext.log || true
run: ci_run cat logs/revert/en/default/external_node.log || true

- name: Show upgrade.log logs
if: always()
Expand Down
Loading
Loading