Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use_dummy_inclusion_data condition #3244

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: use_dummy_inclusion_data condition #3244

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ef1d18
fix: use_dummy_inclusion_data condition
dimazhornyk Nov 11, 2024
2a384f1
Merge branch 'main' into fix-use-dummy-inclusion-data-condition
dimazhornyk Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/node/da_dispatcher/src/da_dispatcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ impl DataAvailabilityDispatcher {
};

let inclusion_data = if self.config.use_dummy_inclusion_data() {
Some(InclusionData { data: vec![] })
} else {
self.client
.get_inclusion_data(blob_info.blob_id.as_str())
.await
Expand All @@ -146,10 +148,6 @@ impl DataAvailabilityDispatcher {
blob_info.blob_id, blob_info.l1_batch_number
)
})?
} else {
// if the inclusion verification is disabled, we don't need to wait for the inclusion
// data before committing the batch, so simply return an empty vector
Some(InclusionData { data: vec![] })
};

let Some(inclusion_data) = inclusion_data else {
Expand Down
Loading