fix: block.timestamp is not accurate #3533
Open
+200
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-nguy
force-pushed
the
thomas/fix-block-timestamp-2
branch
from
ebd99f7 to
bfa0c81
Compare
thomas-nguy
commented
Jan 27, 2025
| @@ -222,7 +222,7 @@ async fn external_io_basics(snapshot_recovery: bool) { | |||
| let tx = create_l2_transaction(10, 100); | |||
| let tx_hash = tx.hash(); | |||
| let tx = FetchedTransaction::new(tx.into()); | |||
| let actions = vec![open_l1_batch, tx.into(), SyncAction::SealL2Block]; | |||
| let actions = vec![open_l1_batch, tx.into(), SyncAction::SealBatch]; | |||
There was a problem hiding this comment.
With the new changes, action that precede an OpenBatch has to be SealBatch
thomas-nguy
commented
Jan 27, 2025
thomas-nguy
force-pushed
the
thomas/fix-block-timestamp-2
branch
3 times, most recently
from
2f68cec to
f690e04
Compare
thomas-nguy
force-pushed
the
thomas/fix-block-timestamp-2
branch
3 times, most recently
from
c5db23f to
005fbe3
Compare
thomas-nguy
force-pushed
the
thomas/fix-block-timestamp-2
branch
from
005fbe3 to
d1594e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Related to zkSync-Community-Hub/zksync-developers#820
Change the l2 block creation logic to start a new l2 block only when a transaction is ready to be executed.
Why ❔
Current logic start a new l2 block as soon as the previous one is sealed.
A contract that relies on
block.timestampwould be able to predict the time correctly because if the l2 block goes stale (no transaction), then it will be open indefinitely and the timestamp will not be accurate anymoreSolution has been tested locally but any feedbacks would be appreciated
Checklist
zkstack dev fmtandzkstack dev lint.