ci: Temporarily comment out contract-verification test #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ly0va
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere and
otani88
Deniallugo
previously approved these changes
Nov 1, 2023
koloz193
previously approved these changes
Nov 1, 2023
StanislavBreadless
previously approved these changes
Nov 1, 2023
koloz193
previously approved these changes
Nov 1, 2023
hatemosphere
previously approved these changes
Nov 1, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ly0va
dismissed stale reviews from hatemosphere, koloz193, and StanislavBreadless
via
2f8c50c
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 35.85% 35.84% -0.01%
==========================================
Files 519 519
Lines 27815 27815
==========================================
- Hits 9972 9971 -1
- Misses 17843 17844 +1 ☔ View full report in Codecov by Sentry. |
|
Sorry about this! We'll release the fix tomorrow. |
StanislavBreadless
approved these changes
Nov 1, 2023
|
@fvictorio It happens to the best of us. Thank you for your hard work on hardhat! |
koloz193
approved these changes
Nov 1, 2023
popzxc
approved these changes
Nov 2, 2023
hatemosphere
approved these changes
Nov 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ly0va
added a commit
that referenced
this pull request
Nov 2, 2023
Commenting out contract-verification test, as it is the only part that gets broken by hardhat-vyper plugin. To make CI work. After NomicFoundation/hardhat#4552 is merged and released, dependencies should be bumped and test should be restored. <!-- Check your PR fulfills the following items. --> <!-- For draft PRs check the boxes as you complete them. --> - [ ] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [ ] Code has been formatted via `zk fmt` and `zk lint`.
|
Hi folks, we just released a new version of Please let us know if you still have problems! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Commenting out contract-verification test, as it is the only part that gets broken by hardhat-vyper plugin.
Why ❔
To make CI work. After NomicFoundation/hardhat#4552 is merged and released, dependencies should be bumped and test should be restored.
Checklist
zk fmtandzk lint.