feat(state-keeper): Remove computational gas limit from boojum protocol version #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deniallugo
previously approved these changes
Nov 23, 2023
RomanBrodetski
force-pushed
the
rb-remove-computation-limit
branch
from
865701c to
d794c27
Compare
Deniallugo
approved these changes
Nov 23, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [18.2.0](core-v18.1.0...core-v18.2.0) (2023-11-27) ### Features * **en:** Implement gossip fetcher ([#371](#371)) ([a49b61d](a49b61d)) * **state-keeper:** reapply computational gas limit ([#544](#544)) ([698dbc3](698dbc3)) * **state-keeper:** Remove computational gas limit from boojum protocol version ([#536](#536)) ([e59a7c6](e59a7c6)) ### Bug Fixes * **core:** differentiate l2 to l1 logs tree size for pre and post boojum batches ([#538](#538)) ([1e9e556](1e9e556)) * **proof_data_handler:** Feature flag state_diff_hash check ([#545](#545)) ([0cab378](0cab378)) * **prover:** use a more performant query to get next job for FRI prover ([#527](#527)) ([2cddf3c](2cddf3c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes
ComputationalGasCriterionfrom post-Boojum versionsWhy
Safety: we do need to properly test this on stage before we upgrade mainnet. We should also discuss if want to introduce some limit - even though there is no hard limit