feat(api): add pessimistic overhead for L1->L2 transactions #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StanislavBreadless
changed the title
perekopskiy
approved these changes
Jan 11, 2024
…ibility-mode-for-l1-txs
…ibility-mode-for-l1-txs
…ibility-mode-for-l1-txs
StanislavBreadless
merged commit 0862373
into
sb-short-term-fee-model-1-4-1
21 of 33 checks passed
StanislavBreadless
deleted the
sb-introduce-compatibility-mode-for-l1-txs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
During the switch to the 1.4.1 protocol version, there will be a moment of discrepancy, when while the L2 has already upgraded to 1.4.1 (and thus suggests smaller overhead), the L1 is still on the previous version.
This might lead to situations when L1->L2 transactions estimated with the new versions would work on the state keeper side, but they won't even make it there, but the protection mechanisms for L1->L2 transactions will reject them on L1.
Why ❔
Checklist
zk fmtandzk lint.zk spellcheck.