Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bug fixing + tests #111

Merged
merged 3 commits into from
Feb 7, 2025
Merged

feat: Bug fixing + tests #111

merged 3 commits into from
Feb 7, 2025

Conversation

Fitznik
Copy link
Contributor

@Fitznik Fitznik commented Feb 7, 2025

Cover exception cases:

  • G1 infinity point, the result should be zero, and the point should be masked
  • G2 infinity point, the result should be zero, and the point should be masked
  • G1 and G2 are not on the curve; the result should be masked, but success should be true

Fixed bugs:

  • bug in subgroup check
  • bug in Oracle
  • Pairing did not correctly handle infinity points

@Fitznik Fitznik requested a review from mm-zk February 7, 2025 01:49
Copy link

@koloz193 koloz193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing but code looks good to me

@Fitznik Fitznik changed the title bug fixing + tests feat: Bug fixing + tests Feb 7, 2025
@mm-zk mm-zk merged commit f253027 into feature/ec_precompiles Feb 7, 2025
6 of 7 checks passed
@mm-zk mm-zk deleted the oo_circuits_fixes branch February 7, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants