-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alamofire lib and use it #40
Comments
Hooray @klymenkoo! welcome to the club! 👍 |
@skywinder, sounds good. I'll keep you up to date with my progress. |
@skywinder, @BaldyAsh, I have migrated all However, I'm a little bit confused with AlamofireWrapper class, how exactly do you see its implementation? I am not sure if it's beneficial to have a wrapper around Alamofire as each Alamofire request inside |
@klymenkoo Everything is great 🙌Thank you so much for your work and interest in our project! Hoping to see you again 🔥And have fun Hacktoberfesting 🎃 |
Fix issue #40: Migrated from URLSession to Alamofire lib.
Current behavior:
Now it is native URLSession used to load some data and interact with APIs.
Expected behavior:
Add Alamofire lib and rewrite URLSessions with Alamofire.
Suggested solution:
You can add Alamofire lib via CocoaPods.
Now only 4 files need to be changed: look at @klymenkoo comment.
All networking should be the separate class, that has functions with required parameters and do all the work by Alamofire.
Acceptance Criteria:
The code is written in new branch named feature/Alamofire or something like that.
The code implements the targets described above.
The code can be merged into the develop branch without conflicts.
Required Skill:
Participants needs to have a bit of experience in Swift software development.
The text was updated successfully, but these errors were encountered: