Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alamofire lib and use it #40

Closed
TonioMacaronio opened this issue Sep 29, 2018 · 5 comments
Closed

Add Alamofire lib and use it #40

TonioMacaronio opened this issue Sep 29, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@TonioMacaronio
Copy link
Contributor

TonioMacaronio commented Sep 29, 2018

Current behavior:
Now it is native URLSession used to load some data and interact with APIs.

Expected behavior:
Add Alamofire lib and rewrite URLSessions with Alamofire.

Suggested solution:
You can add Alamofire lib via CocoaPods.
Now only 4 files need to be changed: look at @klymenkoo comment.
All networking should be the separate class, that has functions with required parameters and do all the work by Alamofire.

Acceptance Criteria:
The code is written in new branch named feature/Alamofire or something like that.
The code implements the targets described above.
The code can be merged into the develop branch without conflicts.

Required Skill:
Participants needs to have a bit of experience in Swift software development.

@TonioMacaronio TonioMacaronio added enhancement New feature or request good first issue Good for newcomers Hacktoberfest labels Sep 29, 2018
@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 1, 2018

I would love to work on this issue if it is okay.

As I see 4 files need to be changed:

screen shot 2018-10-01 at 5 57 08 pm

@skywinder
Copy link
Collaborator

Hooray @klymenkoo! welcome to the club! 👍
That's right, it's just a 4 requests for now. We want to wrap it in a separate class, that will send specialized requests.
So, in the end, it should be the separate class, that has 4 functions with required parameters and do all the work by Alamofire.

@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 2, 2018

@skywinder, sounds good. I'll keep you up to date with my progress.

@vldmrkl
Copy link
Contributor

vldmrkl commented Oct 4, 2018

@skywinder, @BaldyAsh, I have migrated all URLSession requests to Alamofire.

However, I'm a little bit confused with AlamofireWrapper class, how exactly do you see its implementation?

I am not sure if it's beneficial to have a wrapper around Alamofire as each Alamofire request inside TokenService, FiatService, etc. has its own unique behavior.

@TonioMacaronio
Copy link
Contributor Author

@klymenkoo Everything is great 🙌Thank you so much for your work and interest in our project! Hoping to see you again 🔥And have fun Hacktoberfesting 🎃

TonioMacaronio added a commit that referenced this issue Oct 10, 2018
Fix issue #40: Migrated from URLSession to Alamofire lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants