Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TomTom Go navigation support #125

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

frankvollebregt
Copy link
Contributor

@frankvollebregt frankvollebregt commented Aug 9, 2022

closes #124
contributes to #111

This PR adds support for the TomTom Go navigation app on Android and iOS.

What it does

It uses the /navigate URL on iOS, both for navigation and for showing markers, as no documentation of other URLs could be found.

On Android, it uses the geo intent for showing markers, and the google.navigation URL for navigation.

Limitations

  • The SVG image is a converted PNG icon, and has a relatively low quality (the stripes in the background are simply not present in this version), while still being a very large file...
  • No titles or other parameters are supported
  • On iOS, show marker starts navigation anyways

Testing

The marker and directions command were both verified to work on the following devices:

  • Xiaomi Mi A2 running Android 10
  • iPhone 7 running iOS 15.2.1

@frankvollebregt frankvollebregt marked this pull request as ready for review August 9, 2022 08:55
Copy link
Owner

@mattermoran mattermoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, cheers!
No worries about the icon, I will update it

lib/src/directions_url.dart Outdated Show resolved Hide resolved
lib/src/directions_url.dart Outdated Show resolved Hide resolved
Delete unnecessary else statements and add trailing commas for better formatting of the queryParams maps
@mattermoran mattermoran merged commit 768dfd0 into mattermoran:master Aug 9, 2022
@mattermoran
Copy link
Owner

Awesome, will update the icon today and make a new release on pub :)

@mattermoran mattermoran mentioned this pull request Aug 10, 2022
10 tasks
@mattermoran
Copy link
Owner

This is now available in version 2.3.0 on pub. Sorry for delay, had to update the icon :)
Appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting new navigation apps to work
2 participants