feat: add support for tomtom go fleet & Sygic Truck #158
Conversation
|
@mattermoran |
There was a problem hiding this comment.
Perhaps you could give the tomtomgofleet.svg file a solid white background, so that it won't be near invisible on a dark screen.
Should be easy using something like:
<rect width="480" height="480" fill="#fff"/>Also, you've added the svg-ified image of the car app, while you added the truck app. So either replace the image with the Truck image, or perhaps we should consider adding the non-truck Cygic app too, as it should work identically to the truck version.
Additionally, on my device (Google Pixel 7), the Sygic app does not show up in the available maps even though it is installed. This seems to be a separate issue, I'll just create another one in this repo to further discuss it.
| print(url); | ||
| print(url); | ||
| print(url); | ||
| print(url); |
There was a problem hiding this comment.
This should probably be removed before merging this into the package
|
@amrahmed242 Thanks for contribution! |
|
It seems like these two apps weren't added to the README file yet in the master branch, so perhaps it'd be good to do that in additon to the changes I proposed above @mattermoran Edit: I won't have time today I think, so feel free to do it yourself. Below are the tasks I've identified -> Leaving the following tasks:
|
|
Released now in v3 :) Sygic non truck will have to come later otherwise it would've kept dragging |
What the PR Includes
Limitations
The SVG image is a converted PNG icon, and has a relatively low quality.
No titles or other parameters are supported for Sygic.
Tesing
The marker and directions command were both verified to work on the following devices.