Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mapy cz #171

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

TheHumr
Copy link
Contributor

@TheHumr TheHumr commented Feb 27, 2024

No description provided.

TheHumr and others added 5 commits January 22, 2022 12:12
# Conflicts:
#	android/src/main/kotlin/com/alexmiller/map_launcher/MapLauncherPlugin.kt
#	ios/Classes/SwiftMapLauncherPlugin.swift
#	lib/src/directions_url.dart
#	lib/src/marker_url.dart
#	lib/src/models.dart
@mattermoran mattermoran mentioned this pull request Mar 6, 2024
10 tasks
@12people
Copy link

12people commented Mar 7, 2024

It's not working on Android because <package android:name="cz.seznam.mapy" /> is missing from AndroidManifest.xml.

@mattermoran
Copy link
Owner

I don't know if it even works with that thing added in manifest. I checked the docs and it says url coords should be in the q param but here it's in the id

@mattermoran
Copy link
Owner

@TheHumr could you provide a video of it working on android and ios?
also the docs say it does support the google-maps-like urls for direction which is not implemented

@12people
Copy link

12people commented Mar 7, 2024

I don't know if it even works with that thing added in manifest. I checked the docs and it says url coords should be in the q param but here it's in the id

It worked for me — at least, the directions link I tried worked. (Though only linking to the place and not to directions, as the API says that there's no straightforward way to build direction links.)

That said, if the docs recommend another type of linking, the code should probably be adjusted for that.

@mattermoran
Copy link
Owner

The docs say it supports google urls for marker and navigation I wonder if we can just use the existing google format and just trigger mapycz intent
image

@mattermoran
Copy link
Owner

I'm going to give it a go

@mattermoran
Copy link
Owner

Well nevermind, seems like current approach is probably best. Their docs suck, even the examples they themself provide don't work

No Activity found to handle Intent { act=android.intent.action.VIEW dat=http://maps.google.com/... flg=0x10000000 pkg=cz.seznam.mapy }, null, android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW dat=http://maps.google.com/... flg=0x10000000 pkg=cz.seznam.mapy }

I tested on both android and ios and it seems to be working.

I'll get this merged

@mattermoran mattermoran merged commit 6550473 into mattermoran:master Mar 7, 2024
@mattermoran
Copy link
Owner

Published 3.2.0 with those changes.

Thanks @TheHumr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants