Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a database migration to restore the fileinfos that are deleted #4815

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mgdelacroix
Copy link
Contributor

Summary

This migration restores wrongly deleted FileInfos for boards.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53714

@mgdelacroix mgdelacroix added the 2: Dev Review Requires review by a core committer label Jul 21, 2023
Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler...LGTM

Comment on lines +2 to +5
UPDATE FileInfo
SET DeleteAt = 0
WHERE CreatorId = 'boards'
AND DeleteAt != 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, does this mean we undelete everything boards has ever deleted? And that we'll figure out what /should/ be deleted in a separate PR?

@mgdelacroix mgdelacroix merged commit 257cc5f into main Jul 21, 2023
@mgdelacroix mgdelacroix deleted the mm-53714-fix-soft-deleted-boards-file-infos branch July 21, 2023 17:42
@mgdelacroix
Copy link
Contributor Author

/cherry-pick release-7.8

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mgdelacroix
Copy link
Contributor Author

/cherry-pick release-7.9

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jul 21, 2023
@mattermost-build mattermost-build added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Jul 21, 2023
@mgdelacroix
Copy link
Contributor Author

/cherry-pick release-7.10

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jul 21, 2023
@mgdelacroix
Copy link
Contributor Author

/cherry-pick release-7.11

@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jul 21, 2023
mattermost-build pushed a commit to mattermost-build/focalboard that referenced this pull request Jul 21, 2023
mgdelacroix added a commit that referenced this pull request Jul 21, 2023
sbishel pushed a commit that referenced this pull request Jul 21, 2023
sbishel pushed a commit that referenced this pull request Jul 21, 2023
sbishel pushed a commit that referenced this pull request Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants