Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate action to native js #13

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

toninis
Copy link
Contributor

@toninis toninis commented Apr 12, 2024

Summary

Migrate Action to native JS

Ticket Link

https://mattermost.atlassian.net/browse/CLD-7216

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@toninis toninis force-pushed the feat/migrate-action-to-js branch 5 times, most recently from 11c078a to 6df7265 Compare April 12, 2024 13:53
@toninis toninis force-pushed the feat/migrate-action-to-js branch from 6df7265 to 190159c Compare April 12, 2024 13:55
@toninis toninis force-pushed the feat/migrate-action-to-js branch from 190159c to fdd99e0 Compare April 12, 2024 14:04
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toninis! Overall looks good to me, except one clarification on license declaration.

.github/workflows/check-dist.yml Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@toninis toninis requested a review from saturninoabril April 15, 2024 09:30
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @toninis, great to see this updated!

@toninis toninis merged commit b7d118e into master Apr 15, 2024
5 checks passed
@toninis toninis deleted the feat/migrate-action-to-js branch April 15, 2024 09:43
phoinixgrr added a commit to mattermost/mattermost-marketplace that referenced this pull request Jul 24, 2024
phoinixgrr added a commit to mattermost/mattermost-marketplace that referenced this pull request Jul 24, 2024
Alligning the action with the breaking changes introduced under mattermost/action-mattermost-notify#13

Ticket: https://mattermost.atlassian.net/browse/CLD-8100
Signed-off-by: Akis Maziotis <[email protected]>
hanzei pushed a commit to mattermost/mattermost-marketplace that referenced this pull request Jul 24, 2024
Alligning the action with the breaking changes introduced under mattermost/action-mattermost-notify#13

Ticket: https://mattermost.atlassian.net/browse/CLD-8100
Signed-off-by: Akis Maziotis <[email protected]>
hanzei added a commit to mattermost/mattermost-marketplace that referenced this pull request Jul 24, 2024
Alligning the action with the breaking changes introduced under mattermost/action-mattermost-notify#13

Ticket: https://mattermost.atlassian.net/browse/CLD-8100

Signed-off-by: Akis Maziotis <[email protected]>
Co-authored-by: Akis Maziotis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants