[MM-44651] Implement MaxCallParticipants config setting #6334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
|
@amyblais This is the last PR we are planning to include in 1.53 |
amyblais
added
the
CherryPick/Approved
enahum
approved these changes
Jun 2, 2022
|
From what I could see, given the issues with testing mattermost/mattermost-plugin-calls#93 , this should work as expected. Let's ship it. |
cpoile
approved these changes
Jun 2, 2022
amyblais
added
the
4: Reviews Complete
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-mobile
that referenced
this pull request
Jun 3, 2022
) * Implement MaxCallParticipants config setting * Add test (cherry picked from commit bb655c8)
mattermod
added
CherryPick/Done
streamer45
added a commit
that referenced
this pull request
Jun 3, 2022
* Implement MaxCallParticipants config setting * Add test (cherry picked from commit bb655c8) Co-authored-by: Claudio Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR makes the necessary changes to support the new
MaxCallParticipantsconfig setting.@cpoile Again I tried to simplify as much as possible but will need some help testing this to make sure I haven't missed some edge case.
Ticket Link
https://mattermost.atlassian.net/browse/MM-44651
Checklist
Related PRs
mattermost/mattermost-plugin-calls#93
Release Note