Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-51581] Upgrade dependencies and cleanup #347

Merged
merged 15 commits into from
May 23, 2023
Merged

[MM-51581] Upgrade dependencies and cleanup #347

merged 15 commits into from
May 23, 2023

Conversation

fmartingr
Copy link
Contributor

@fmartingr fmartingr commented Mar 23, 2023

Summary

Upgrade all operator dependencies and remove the block mysql-operator has on k8s dependencies:

  • Removed mysql-operator dependency
    • Using a copy of the manifests directly in the repo, so we dont have to maintain our own templates, based on the same version the repository already uses (presslabs rather than bitpokes).
    • Modified some Makefile commands to avoid them from modifying those files.
  • testify to 1.8.2
  • golang.org/x/net v0.8.0
  • banzaicloud/k8s-objectmatcher v1.8.0
  • k8s.io/* v0.26.3
  • k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a
  • sigs.k8s.io/controller-runtime v0.14.5

Ticket Link

https://mattermost.atlassian.net/browse/MM-51581

Release Note

feat: upgrade all dependencies

@fmartingr fmartingr self-assigned this Mar 23, 2023
@mm-cloud-bot mm-cloud-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 23, 2023
k8s.io/api v0.26.3
k8s.io/apimachinery v0.26.3
k8s.io/client-go v0.26.3
k8s.io/code-generator v0.26.3
k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a
sigs.k8s.io/controller-runtime v0.14.5

Updated controller-gen code
Ignore modifications to mysql_operator files
@fmartingr fmartingr changed the title [MM-51581] Upgrade dependencies and cleanup (WIP) [MM-51581] Upgrade dependencies and cleanup Mar 24, 2023
@fmartingr fmartingr requested review from gabrieljackson and mirshahriar and removed request for gabrieljackson March 24, 2023 13:45
Copy link
Contributor

@mirshahriar mirshahriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work.

@gabrieljackson
Copy link
Collaborator

Heya, let me know if this can be reviewed as is or if it should be freshened up a bit. Thanks!

@fmartingr
Copy link
Contributor Author

Heya, let me know if this can be reviewed as is or if it should be freshened up a bit. Thanks!

Let me check if there are more updates, but it should be reviewable.

@fmartingr
Copy link
Contributor Author

Heya, let me know if this can be reviewed as is or if it should be freshened up a bit. Thanks!

There's an issue when updating the k8s deps to 0.27. There's an impossible type assertion somewhere in a dependency.

Copy link
Collaborator

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: to clarify, I am okay getting us up to .26 and we can do a follow-up if necessary.

@fmartingr fmartingr merged commit 51ca1a9 into master May 23, 2023
@fmartingr fmartingr deleted the feat/MM-51581 branch May 23, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants