-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-51581] Upgrade dependencies and cleanup #347
Conversation
72ede87
to
1d63bd1
Compare
k8s.io/api v0.26.3 k8s.io/apimachinery v0.26.3 k8s.io/client-go v0.26.3 k8s.io/code-generator v0.26.3 k8s.io/kube-openapi v0.0.0-20230308215209-15aac26d736a sigs.k8s.io/controller-runtime v0.14.5 Updated controller-gen code Ignore modifications to mysql_operator files
2cd1714
to
c4395ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Work.
Heya, let me know if this can be reviewed as is or if it should be freshened up a bit. Thanks! |
Let me check if there are more updates, but it should be reviewable. |
There's an issue when updating the k8s deps to 0.27. There's an impossible type assertion somewhere in a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Edit: to clarify, I am okay getting us up to .26 and we can do a follow-up if necessary.
Summary
Upgrade all operator dependencies and remove the block mysql-operator has on k8s dependencies:
Makefile
commands to avoid them from modifying those files.Ticket Link
https://mattermost.atlassian.net/browse/MM-51581
Release Note