MM-56014 - Fix type error (#585)

* fix threadIDForCurrentCall selector * Bump wait --------- Co-authored-by: streamer45 <[email protected]>
mattermost · Dec 11, 2023 · 265c20c · 265c20c
1 parent f5dc9c4
commit 265c20c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/e2e/tests/popout.spec.ts b/e2e/tests/popout.spec.ts
@@ -281,7 +281,7 @@ test.describe('popout window', () => {
         await replyTextbox.press('Enter');
 
         // Verify we left the call.
-        await devPage.wait(1000);
+        await devPage.wait(2000);
         await expect(popOut.isClosed()).toEqual(true);
         await expect(page.locator('#calls-widget')).toBeHidden();
     });

diff --git a/webapp/src/selectors.ts b/webapp/src/selectors.ts
@@ -63,6 +63,14 @@ export const idForCurrentCall: (state: GlobalState) => string | undefined =
         (callsStates, channelID) => callsStates[channelID]?.ID,
     );
 
+export const threadIDForCurrentCall: (state: GlobalState) => string | undefined =
+    createSelector(
+        'threadIDForCurrentCall',
+        calls,
+        channelIDForCurrentCall,
+        (callsStates, channelID) => callsStates[channelID]?.threadID,
+    );
+
 export const teamForCurrentCall: (state: GlobalState) => Team | null =
     createSelector(
         'teamForCurrentCall',
@@ -159,7 +167,7 @@ export const callStartAtForCurrentCall: (state: GlobalState) => number =
           window.opener?.callsClient?.initTime || 0,
     );
 
-export const callInCurrentChannel: (state: GlobalState) => callState =
+export const callInCurrentChannel: (state: GlobalState) => callState | undefined =
     createSelector(
         'callInCurrentChannel',
         calls,
@@ -216,9 +224,6 @@ export const threadIDForCallInChannel = (state: GlobalState, channelID: string)
     return pluginState(state).calls[channelID]?.threadID || '';
 };
 
-export const threadIDForCurrentCall = (state: GlobalState) =>
-    callInCurrentChannel(state).threadID;
-
 const recordingsForCalls = (state: GlobalState): callsRecordingsState => {
     return pluginState(state).recordings;
 };