MM-54313 - Fix: panic in handleGetAllChannels (#511)

* fix MM-54313 * wrap appErr
mattermost · Aug 31, 2023 · fe6f2e0 · fe6f2e0
1 parent 1ee23b8
commit fe6f2e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/server/api.go b/server/api.go
@@ -139,7 +139,7 @@ func (p *Plugin) handleGetAllChannels(w http.ResponseWriter, r *http.Request) {
 			state, err := p.kvGetChannelState(channelID, false)
 			if err != nil {
 				p.LogError(err.Error())
-				http.Error(w, appErr.Error(), http.StatusInternalServerError)
+				continue
 			}
 
 			enabled := state.Enabled

diff --git a/server/store.go b/server/store.go
@@ -53,7 +53,7 @@ func (p *Plugin) KVGet(key string, fromWriter bool) ([]byte, error) {
 	if !fromWriter {
 		data, appErr := p.API.KVGet(key)
 		if appErr != nil {
-			return nil, appErr
+			return nil, fmt.Errorf("failed to kvget for key: %s error: %w", key, appErr)
 		}
 		return data, nil
 	}