[MM-42101] Implement option to enable calls by default #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Feb 28, 2022
Comment on lines
+72
to
+75
| if cfg.DefaultEnabled != nil && *cfg.DefaultEnabled { | ||
| state = &channelState{ | ||
| Enabled: true, | ||
| } |
There was a problem hiding this comment.
This essentially means we are implicitly enabling channels calls upon first call. An alternate approach was to leave it unset but that required data schema changes (converting bool to pointer to have the additional state) and it felt more convoluted overall. Happy to hear feedback though.
streamer45
commented
Feb 28, 2022
Comment on lines
+81
to
+83
| if !state.Enabled { | ||
| return nil, fmt.Errorf("calls are not enabled") | ||
| } |
There was a problem hiding this comment.
Interestingly, from a server perspective it was possible to start a call on a channel with calls disabled.
streamer45
commented
Feb 28, 2022
| @@ -112,8 +112,7 @@ export default class CallsClient extends EventEmitter { | |||
| this.ws = ws; | |||
|
|
|||
| ws.on('error', (err) => { | |||
| console.log(`ws error: ${err}`); | |||
| this.ws = null; | |||
There was a problem hiding this comment.
This was preventing the ws connection from disconnecting in case of server side error (e.g. during join).
cpoile
approved these changes
Feb 28, 2022
| @@ -112,8 +112,7 @@ export default class CallsClient extends EventEmitter { | |||
| this.ws = ws; | |||
|
|
|||
| ws.on('error', (err) => { | |||
| console.log(`ws error: ${err}`); | |||
| this.ws = null; | |||
cpoile
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are adding a new
DefaultEnabledconfig option that controls whether Calls should be enabled in all channels by default (opt-out model).Ticket Link
https://mattermost.atlassian.net/browse/MM-42101