Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-44946: Fix: Calls: start trial path from Start Call button not working #105

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Jun 9, 2022

Summary

  • Use the openCloudPricing flow instead of our homegrown trial path because the code changed on webapp/server and broke our flow; it's too late to export the webapp's flow for this, so we're using the CloudPricing modal as a temporary measure to make things work for launch.
  • Next step tracked in: https://mattermost.atlassian.net/browse/MM-44992

Ticket Link

@cpoile cpoile requested a review from streamer45 June 9, 2022 22:10
@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Jun 9, 2022
@cpoile
Copy link
Member Author

cpoile commented Jun 9, 2022

I'm not able to test this, unfortunately (split.io). So I'll ask for a review now and hope something changes tomorrow, but probably not in the time we have. (Do we even have time? I'm unsure whether we can fix this before release.)

@streamer45
Copy link
Collaborator

I'm not able to test this, unfortunately (split.io). So I'll ask for a review now and hope something changes tomorrow, but probably not in the time we have. (Do we even have time? I'm unsure whether we can fix this before release.)

We don't have time to include it in 7.0/cloud build but what we can probably do, similarly to other bugs (e.g. the thread autofollow one) we can cut a new release later today, push it to the marketplace and force an update on cloud (through split). That should give us what we want without going through pre-packaging.

@cpoile
Copy link
Member Author

cpoile commented Jun 10, 2022

@streamer45 Ok, that sounds good, let's do that. 👍

@streamer45
Copy link
Collaborator

@cpoile Do you want to test this before or after merging?

@cpoile
Copy link
Member Author

cpoile commented Jun 10, 2022

@streamer45 Do we need to test anything else in this batch? If not, I can cut it from this hash.

@streamer45
Copy link
Collaborator

@cpoile I think this is the only PR requiring an actual Cloud instance to be verified so I'd say this is it. I don't have to merge anything else for v0.6.1 (or whatever it's going to be).

@cpoile
Copy link
Member Author

cpoile commented Jun 10, 2022

/update-branch

@cpoile
Copy link
Member Author

cpoile commented Jun 10, 2022

Huh, guess that doesn't work because we use main?

@cpoile cpoile merged commit fb2eef2 into main Jun 10, 2022
@cpoile cpoile deleted the MM-44946-fix-start-trial-path branch June 10, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants