[MM-42347] Fix UDP conn not respecting deadlines #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR fixes an issue with the UDP server connection not respecting the defined deadlines and hence potentially getting stuck indefinitely in case of an unreachable host.
After some testing and looking into the standard library I've figure out this was actually caused by the call on
File.Fd()
we do here:mattermost-plugin-calls/server/activate.go
Lines 55 to 64 in 4ac8eb9
As suggested in the official documentation we are now using
File.SyscallConn()
instead which seems to avoid this problem.Ticket Link
https://mattermost.atlassian.net/browse/MM-42347