[MM-42574] Single handler mode #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Apr 4, 2022
Comment on lines
+53
to
+55
| if unquoted == "" { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
This fixes an issue when no STUN servers are passed. Instead of an empty slice of strings we were getting a slice with a single empty string which was making connection fail.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR implements a special single handler mode that allows calls to be hosted on a single instance in a HA cluster through the use of the
CALLS_IS_HANDLER=trueenvironment variable. This is how our community installation has been operating so far. The only relevant addition from the community branch is the extra expiry check which is needed to avoid potential issues with the state getting messed up due to the handler node crashing without cleaning up.Ticket Link
https://mattermost.atlassian.net/browse/MM-42574