[MM-53433] Use JobID to differentiate bot initiated sessions #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
Jun 28, 2023
webapp/src/types/types.ts
Outdated
Comment on lines
25
to
34
| export type CallsClientJoinData = { | ||
| channelID: string; | ||
| title?: string; | ||
| threadID?: string; | ||
|
|
||
| // Calls bot only | ||
| // contextID is the id used to track the context of the bot connection to | ||
| // a call (e.g. recording, transcription). | ||
| contextID?: string; | ||
| } |
There was a problem hiding this comment.
I think this could fit in https://github.com/mattermost/calls-common since it's part of the public API. For this PR though it's practically unnecessary.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
========================================
- Coverage 5.62% 5.57% -0.05%
========================================
Files 21 21
Lines 4178 4213 +35
========================================
Hits 235 235
- Misses 3926 3961 +35
Partials 17 17
☔ View full report in Codecov by Sentry. |
|
Will have to update the calls-recorder image we use in the Gitlab pipeline to make e2e pass. |
cpoile
approved these changes
Jun 30, 2023
streamer45
added
3: Reviews Complete
streamer45
changed the title
|
@cpoile Heads up, I applied the changes as suggested in mattermost/rtcd#115 (comment) |
streamer45
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the introduction of new job types (e.g. transcriptions) we need a way to properly identify bot initiated sessions. So far we assumed all bot connections were recording related but that won't always be the case going forward. The idea is to pass a
ContextIDJobIDparameter that univocally identifies a resource/job type.Related PR
mattermost/calls-recorder#38
Ticket Link
https://mattermost.atlassian.net/browse/MM-53433