Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-53988] Improve logic for showing recording stopped banner #491

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

streamer45
Copy link
Collaborator

@streamer45 streamer45 commented Aug 9, 2023

Summary

PR fixes an issues that would cause the Recording has stopped. Processing... message to appear to a newly changed host regardless of when the recording ended.

I am adding a threshold (currently one minute) after which we wouldn't show this. Technically we could just show it to the host at the time of stopping the recording but felt it may be useful to keep it around in case of a sudden host change. Overall though I don't have a strong opinion myself and feel it's more of a UX decision.

Regardless of what we do here, at some point (likely as part of host controls) we may want to design a message to inform a user that they became the host.

/cc @matthewbirtch in case you'd like to chime in on any of the above.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53988

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Aug 9, 2023
@streamer45 streamer45 added this to the v0.19.0 - MM 9.0 milestone Aug 9, 2023
@streamer45 streamer45 requested a review from cpoile August 9, 2023 20:36
@streamer45 streamer45 self-assigned this Aug 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08% ⚠️

Comparison is base (5c059da) 5.62% compared to head (65296e0) 5.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #491      +/-   ##
========================================
- Coverage   5.62%   5.55%   -0.08%     
========================================
  Files         21      21              
  Lines       4178    4178              
========================================
- Hits         235     232       -3     
- Misses      3926    3928       +2     
- Partials      17      18       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewbirtch
Copy link
Contributor

I am adding a threshold (currently one minute) after which we wouldn't show this. Technically we could just show it to the host at the time of stopping the recording but felt it may be useful to keep it around in case of a sudden host change. Overall though I don't have a strong opinion myself and feel it's more of a UX decision.

To be honest, I'm not sure if this is something we need to do. It doesn't seem all that important to me. I'd say leave it out.

Regardless of what we do here, at some point (likely as part of host controls) we may want to design a message to inform a user that they became the host.

I agree that we will want to do this as part of host controls effort (although I dont' know if/when that will get roadmapped).

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Aug 18, 2023
@streamer45 streamer45 merged commit 5f107f9 into main Aug 21, 2023
@streamer45 streamer45 deleted the MM-53988 branch August 21, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants