[MM-53988] Improve logic for showing recording stopped banner #491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR fixes an issues that would cause the Recording has stopped. Processing... message to appear to a newly changed host regardless of when the recording ended.
I am adding a threshold (currently one minute) after which we wouldn't show this. Technically we could just show it to the host at the time of stopping the recording but felt it may be useful to keep it around in case of a sudden host change. Overall though I don't have a strong opinion myself and feel it's more of a UX decision.Regardless of what we do here, at some point (likely as part of host controls) we may want to design a message to inform a user that they became the host.
/cc @matthewbirtch in case you'd like to chime in on any of the above.
Ticket Link
https://mattermost.atlassian.net/browse/MM-53988