[MM-54157] Fix potential nil access upon starting a recording #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
commented
Aug 16, 2023
Comment on lines
-188
to
-198
| // Sending the event prior to making the API call to the job service | ||
| // since it could take a few seconds to complete but we want clients | ||
| // to get their local state updated as soon as it changes on the server. | ||
| p.publishWebSocketEvent(wsEventCallRecordingState, map[string]interface{}{ | ||
| "callID": callID, | ||
| "recState": recState.getClientState().toMap(), | ||
| }, &model.WebsocketBroadcast{ChannelId: callID, ReliableClusterSend: true}) | ||
|
|
||
| // We don't want to keep the lock while making the API call to the service since it | ||
| // could take a while to return. | ||
| p.unlockCall(callID) |
There was a problem hiding this comment.
Unrelated to the panic but since we moved to the new job API we don't need to do this, the stop action is completely asynchronous and safe to be called under lock.
streamer45
commented
Aug 16, 2023
Comment on lines
+39
to
+42
| if recState.JobID != jobID { | ||
| p.LogInfo("a new job has started in between, exiting", "callID", callID, "jobID", jobID) | ||
| return | ||
| } |
There was a problem hiding this comment.
Adding an extra check to avoid making potentially inconsistent state updates due to previously failed jobs. Ideally we'd cancel this timeout check whenever we stop a recording but the synchronization needed would make the code more complex so it seems like a few extra goroutines that return early are not too bad.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## MM-53162 #495 +/- ##
===========================================
+ Coverage 5.39% 5.45% +0.05%
===========================================
Files 23 23
Lines 4297 4309 +12
===========================================
+ Hits 232 235 +3
- Misses 4047 4057 +10
+ Partials 18 17 -1
☔ View full report in Codecov by Sentry. |
cpoile
approved these changes
Aug 18, 2023
streamer45
added
3: Reviews Complete
streamer45
added a commit
that referenced
this pull request
Aug 28, 2023
… state operations (#460) * Refactor cluster mutex * Call locking utils * Add/remove session * Mute/Unmute,RaiseHand/LowerHand,ScreenSharing * Call start post * Call end * Enable/disable calls * Recording API * Remove unused functions * Mutex metrics * Lint fixes * Update .golangci.yml * Writer DB * Simplify call lock use * Simplify call start case * Fix KVGet semantic in case of no results * Small tweaks * Make Unlock() actually safe * Simplify recording API handlers * Move code around * Prevent logging errors on duplicate session removals attempts * Enforce maxPollInterval * Add note to cleanCallState function * Use channelID instead of callID * Update new code * [MM-53167] Persist participants list (#486) * Persist list of participants on call end * Exclude bot from participants list * Fix potential nil access upon starting a recording (#495) * fix linter errors * Bump golangci-lint version * Force input * Revert "Force input" This reverts commit 0b22839. --------- Co-authored-by: Christopher Poile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR fixes a potential panic due to accessing a
nilrecState.Ticket Link
https://mattermost.atlassian.net/browse/MM-54157