Implement setup flag for load-test client
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
3: Reviews Complete
streamer45
changed the title
no-setup flag for load-test clientsetup flag for load-test client
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
========================================
- Coverage 5.62% 5.60% -0.03%
========================================
Files 21 21
Lines 4178 4193 +15
========================================
Hits 235 235
- Misses 3926 3941 +15
Partials 17 17 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I used to constantly patch the local load-test client every time I wanted to test on Community since we cannot use a system admin account there. So I am adding a proper
setupflag that when set tofalseavoids any sort of setup (e.g. registering users, joining channels) which works well for cases where the needed entities are already in place.