[MM-54216] Bump ws rate limiting burst #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
========================================
- Coverage 5.60% 5.60% -0.01%
========================================
Files 21 21
Lines 4193 4194 +1
========================================
Hits 235 235
- Misses 3941 3942 +1
Partials 17 17
☔ View full report in Codecov by Sentry. |
cpoile
approved these changes
Aug 23, 2023
| @@ -47,7 +47,8 @@ type session struct { | |||
| leaveCh chan struct{} | |||
| left int32 | |||
|
|
|||
| limiter *rate.Limiter | |||
| // rate limiter for incoming WebSocket messages. | |||
| wsMsgLimiter *rate.Limiter | |||
There was a problem hiding this comment.
Thank you for the nice var name!
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It looks like Firefox can be spamming a very long list of candidates if running on an instance with many network interfaces and hit the rate limiter which will drop messages, potentially preventing proper connectivity. What's worse, upon first unmute or screen sharing attempt it will do more of the same.
Note to self: this should be the last time we bump this. If the problem reappears we need to investigate a different solution.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54216