[MM-54192] Implement re-try logic for recording client #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #499 +/- ##
=====================================
Coverage 5.60% 5.60%
=====================================
Files 21 21
Lines 4193 4193
=====================================
Hits 235 235
Misses 3941 3941
Partials 17 17 ☔ View full report in Codecov by Sentry. |
streamer45
added
3: Reviews Complete
|
Tested a bit and it seems like it's doing its job.
|
streamer45
removed
the
Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds some basic re-try logic to asynchronous requests that could fail due to intermittent networking issues. We implement a simple incremental back off algorithm with a configurable maximum number of attempts and retry interval.
Hopefully this will be enough to overcome the existing issues but will need to be verified on Community prior to merging.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54192