Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-54494] Keep backwards compatibility with older MM versions #524

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

streamer45
Copy link
Collaborator

@streamer45 streamer45 commented Sep 13, 2023

Summary

We are still using voiceConnectedProfiles on webapp so we need to continue supporting it at least until we bump minimum server version.

Related PR

mattermost/mattermost#24544

Ticket Link

https://mattermost.atlassian.net/browse/MM-54494

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Sep 13, 2023
@streamer45 streamer45 added this to the v0.19.1 milestone Sep 13, 2023
@streamer45 streamer45 requested a review from cpoile September 13, 2023 17:17
@streamer45 streamer45 self-assigned this Sep 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-0.19@15fd276). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-0.19    #524   +/-   ##
==============================================
  Coverage                ?   5.35%           
==============================================
  Files                   ?      24           
  Lines                   ?    4387           
  Branches                ?       0           
==============================================
  Hits                    ?     235           
  Misses                  ?    4134           
  Partials                ?      18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Sep 13, 2023
@streamer45
Copy link
Collaborator Author

Interesting, the e2e has found a completely unrelated issue.

@streamer45 streamer45 mentioned this pull request Sep 14, 2023
@streamer45
Copy link
Collaborator Author

Going to merge this with the single e2e test failing which we'll sort out after release since it requires upstream changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants