[MM-54551] Fix potential nil dereference panic #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
Sep 26, 2023
|
Any idea why it's returning a nil config? |
Not sure but I think the returned setting is nil, not the config because I had the reporting user setting it to |
|
Also to note, what made debugging this worse was that until we enabled DEBUG level logs we couldn't get the plugin panics to show. Something to review on the server most likely. |
Yeah, currently it's something handled by the framework (https://mattermost.atlassian.net/browse/MM-54562), unless we start to implement recovers, something I tried to avoid so far. |
streamer45
added
3: Reviews Complete
cpoile
pushed a commit
that referenced
this pull request
Oct 2, 2023
Merged
cpoile
added a commit
that referenced
this pull request
Oct 2, 2023
* [MM-54520] Soft fail in case of missing post during state cleanup (#530) * Soft fail in case of missing post during state cleanup * Add validity check on postID * Fix potential nil dereference panic (#532) --------- Co-authored-by: Claudio Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We had a report of failures to join calls starting in v0.19. At first it looked like a networking issue but upon further inspection of the logs we were able to find multiple plugin crashes due to SIGSEGV.
Even if properly set to
falseinconfig.jsonthe returned object was a nil pointer. Adding a couple of extra checks to avoid future regressions.Given the severity of this I'd like to cut a new dot release once this is merged.
Ticket Link
https://mattermost.atlassian.net/browse/MM-54551