MM-54361 - Two cherry picks - #505 and #511

[cpoile]

Summary

• Cherry picks MM-54259 - Fix: Panic in isMobilePostGA #505 and MM-54313 - Fix: panic in handleGetAllChannels #511 to release-0.17 branch for a v0.17.1 dot release, to be prepackaged to the 8.0 release.

Ticket Link

• https://mattermost.atlassian.net/browse/MM-54361

[codecov-commenter]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (67d5dcf) 5.65% compared to head (1353af5) 5.72%.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-0.17    #534      +/-   ##
===============================================
+ Coverage          5.65%   5.72%   +0.06%     
===============================================
  Files                22      22              
  Lines              4155    4157       +2     
===============================================
+ Hits                235     238       +3     
+ Misses             3903    3902       -1     
  Partials             17      17              

Files	Coverage Δ
server/utils.go	29.00% <100.00%> (+2.19%)	⬆️
server/api.go	1.23% <0.00%> (+<0.01%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cpoile]

Looks like there's some issues with the recorder -- Jesse ran into a timeout when pressing record during the Dev meeting, he received a timeout after a minute or two. After pressing record a second time we got the confirmation almost instantly.

[streamer45]

Looks like there's some issues with the recorder -- Jesse ran into a timeout when pressing record during the Dev meeting, he received a timeout after a minute or two. After pressing record a second time we got the confirmation almost instantly.

Yeah, saw some failures alerts. Will look into it.

[cpoile]

@streamer45 Sorry to bug you about it, but can we assume the recording e2e will pass if the recorder was working?

[streamer45]

@streamer45 Sorry to bug you about it, but can we assume the recording e2e will pass if the recorder was working?

We'll have to I think because we made breaking changes which would need us to run a previous calls-offloader version to make e2e pass. I can probably run those locally though just to make extra sure.

[cpoile]

@streamer45 I think, given these minor changes don't touch anything recording related, we don't need to. I'll merge if you're okay with it.

[streamer45]

Alright, it should be safe 👍