Fix build on go1.21 #536
Merged
Fix build on go1.21 #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=====================================
Coverage 5.41% 5.41%
=====================================
Files 24 24
Lines 4394 4394
=====================================
Hits 238 238
Misses 4139 4139
Partials 17 17 ☔ View full report in Codecov by Sentry. |
|
@hanzei Would you mind updating this to point to the latest |
|
Pushed a commit to expedite the release. Will merge, thanks! |
streamer45
approved these changes
Oct 5, 2023
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Downstream mattermost/rtcd#121 to fix the broken CI on
go1.21.Ticket Link
mattermost/actions#13