Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e lint issue #545

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix e2e lint issue #545

merged 2 commits into from
Oct 6, 2023

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Oct 5, 2023

Summary

  • tsconfig/eslint doesn't play nice if you try to include parent or sibling directories, so let's just include the little bit that I was referencing (like we do for other types in the e2e test project).
  • also added the e2e linting to the overall checks... Not sure if you want that, but would have prevented this, so I think it's probably a good thing.

Ticket Link

  • none

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Oct 5, 2023
@cpoile cpoile requested a review from streamer45 October 5, 2023 22:42
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Indeed I'd expect these to run on CI.

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (ca763c1) 5.32% compared to head (9593fb2) 5.25%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #545      +/-   ##
========================================
- Coverage   5.32%   5.25%   -0.07%     
========================================
  Files         24      24              
  Lines       4469    4469              
========================================
- Hits         238     235       -3     
- Misses      4214    4216       +2     
- Partials      17      18       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpoile cpoile merged commit 82ca149 into main Oct 6, 2023
@cpoile cpoile deleted the fix-e2e-lint branch October 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants