[MM-55268] Expose metrics through new ServeMetrics hook
#556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
|
/update-branch |
DHaussermann
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Tested and passed
I can now see metrics exposed at http://localhost:8067/plugins/com.mattermost.calls/metrics
Seems to be functional. I can see metrics when the plugin is in use.
LGTM!
streamer45
added
3: Reviews Complete
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
========================================
- Coverage 5.76% 5.76% -0.01%
========================================
Files 24 24
Lines 4559 4561 +2
========================================
Hits 263 263
- Misses 4278 4280 +2
Partials 18 18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We implement the
ServeMetricshook introduced in mattermost/mattermost#24249.@DHaussermann Adding you since we need some basic QA on the related server side PR. So the QA work is the same for both PRs as we'll be using Calls as a test plugin. We just want to verify that metrics will be exposed under http://localhost:8067/plugins/com.mattermost.calls/metrics when running a build from this PR against a MM server with the changes above.
Ticket Link
https://mattermost.atlassian.net/browse/MM-55268