-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go.mod changes after rebase conflict w/ master
need to update MM hash still
This was referenced Nov 10, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
========================================
- Coverage 5.49% 5.39% -0.11%
========================================
Files 24 24
Lines 4532 4617 +85
========================================
Hits 249 249
- Misses 4265 4350 +85
Partials 18 18
☔ View full report in Codecov by Sentry. |
streamer45
reviewed
Nov 13, 2023
streamer45
reviewed
Nov 13, 2023
streamer45
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bearing with me @cpoile, looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is to support calls-specific push notifications, see also:
This makes a single check on activation for the push proxy version, and uses that version when checking what type of push notification message to send. This lets us be backward compatible with older push proxies and use correct typing in the future for calls push notification messages, which allows us to internationalize the call started push messages in calls v1.0.
Also added a
canSendPushNotifications
method, which we probably should have had...NOTE: will need to update the MM server dependency once that PR is merged.
Ticket Link