Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-55060 - Calls: Add PushTypeCalls for calls-specific push notifications #561

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Nov 10, 2023

Summary

Ticket Link

go.mod changes after rebase conflict w/ master
@codecov-commenter
Copy link

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (a200fc6) 5.49% compared to head (6140596) 5.39%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #561      +/-   ##
========================================
- Coverage   5.49%   5.39%   -0.11%     
========================================
  Files         24      24              
  Lines       4532    4617      +85     
========================================
  Hits         249     249              
- Misses      4265    4350      +85     
  Partials      18      18              
Files Coverage Δ
server/plugin.go 0.00% <ø> (ø)
server/activate.go 0.00% <0.00%> (ø)
server/log.go 0.00% <0.00%> (ø)
server/push_notifications.go 0.00% <0.00%> (ø)
server/utils.go 15.76% <0.00%> (-10.14%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45 streamer45 added this to the v0.21.0 / MM 9.3 milestone Nov 13, 2023
@cpoile cpoile requested a review from streamer45 November 13, 2023 21:53
Copy link
Collaborator

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me @cpoile, looks good!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 13, 2023
@cpoile cpoile merged commit 47cd7a7 into main Nov 14, 2023
@cpoile cpoile deleted the MM-55060-type-calls-push-notifications branch November 14, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants