[MM-43660] Expose some client-side metrics through /call stats command
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
approved these changes
May 3, 2022
| try { | ||
| const stats = await window.callsClient.getStats(); | ||
| console.log(JSON.stringify(stats, null, 2)); | ||
| return {message: `/call stats "${JSON.stringify(stats)}"`, args}; |
There was a problem hiding this comment.
Heh, this is clever. I never would have thought to do this. Makes it simpler to display to the user. 👍
There was a problem hiding this comment.
It's horribly clever 🙈 . To be honest I wanted a way to display an ephemeral message directly from the client but to my surprise it doesn't look like possible. The solution is hacky but it gets the job done so why not.
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new utility command
/call statsto expose some client-side metrics.Command will generate an ephemeral message with the collected metrics in JSON, e.g.:
This will be useful to debug possible client-side conditions (e.g. networking) affecting calls quality.
Ticket Link
https://mattermost.atlassian.net/browse/MM-43660