[MM-55617] Surface config serialization errors #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
========================================
- Coverage 5.77% 5.76% -0.01%
========================================
Files 24 24
Lines 4554 4559 +5
========================================
Hits 263 263
- Misses 4273 4278 +5
Partials 18 18 ☔ View full report in Codecov by Sentry. |
cpoile
approved these changes
Nov 20, 2023
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I am not sure (which slightly worries me) why we didn't handle these. I want to think it was a simple oversight on my part. Still, they require MM >= 8.0 to show so they wouldn't have helped with the recent customer issue.
Ticket Link
https://mattermost.atlassian.net/browse/MM-55617