Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-56089] Multi language support for captions #586

Merged
merged 2 commits into from
Dec 11, 2023
Merged

[MM-56089] Multi language support for captions #586

merged 2 commits into from
Dec 11, 2023

Conversation

streamer45
Copy link
Collaborator

Summary

Adding multi language support to generated captions. The client should now expect a captions: Caption[] field in the recording post props. Tested this in three languages (english, spanish, italian) :)

Ticket Link

https://mattermost.atlassian.net/browse/MM-56089

@streamer45 streamer45 added the 2: Dev Review Requires review by a core committer label Dec 7, 2023
@streamer45 streamer45 added this to the v0.22.0 / MM 9.4 milestone Dec 7, 2023
@streamer45 streamer45 requested a review from cpoile December 7, 2023 23:19
@streamer45 streamer45 self-assigned this Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3957bea) 5.96% compared to head (e2af8d6) 5.90%.

Files Patch % Lines
server/bot_api.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #586      +/-   ##
========================================
- Coverage   5.96%   5.90%   -0.06%     
========================================
  Files         26      26              
  Lines       5181    5181              
========================================
- Hits         309     306       -3     
- Misses      4848    4850       +2     
- Partials      24      25       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@streamer45
Copy link
Collaborator Author

Need to update the transcriber for e2e to pass.

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed 2: Dev Review Requires review by a core committer labels Dec 8, 2023
@streamer45 streamer45 removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Dec 11, 2023
@streamer45 streamer45 merged commit f5dc9c4 into main Dec 11, 2023
@streamer45 streamer45 deleted the MM-56089 branch December 11, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants