[MM-43508] Implement basic reconnection support for rtcd client #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpoile
reviewed
May 4, 2022
go.mod
Outdated
| @@ -15,7 +15,7 @@ require ( | |||
| require ( | |||
| github.com/mattermost/logr/v2 v2.0.15 | |||
| github.com/mattermost/mattermost-plugin-api v0.0.27 | |||
| github.com/mattermost/rtcd v0.3.1-0.20220427165117-035048fda047 | |||
| github.com/mattermost/rtcd v0.3.1-0.20220504082845-a64f36fa09dc | |||
There was a problem hiding this comment.
Oh, this will have to be updated once it's merged (you probably know) -- I was stung once by a branch disappearing on me once. :)
There was a problem hiding this comment.
Yes, I'll probably push a new tag since there are significant changes upstream.
streamer45
added
3: Reviews Complete
streamer45
removed
the
Do Not Merge/Awaiting PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds reconnection support for the rtcd client as implemented in mattermost/rtcd#24
rtcdinstance restarted and wiped its store.maxReconnectAttempts(default to 8) with some incremental backoff (2 seconds).maxReconnectAttemptsis reached we give up and disable the plugin.To note, this doesn't cover initial connection on plugin startup. Adding that support makes the logic even more complex so I opted to keep the assumption that a running
rtcdshould be available when enabling the plugin.Also, this whole logic is going to change a bit when implementing MM-43872 as we are going to deal with multiple concurrent clients but didn't want to couple the two pieces of work so take this as a first iteration.
Ticket Link
https://mattermost.atlassian.net/browse/MM-43508