[MM-56178] Fix failure to update call post (MySQL) #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
========================================
- Coverage 5.96% 5.96% -0.01%
========================================
Files 26 26
Lines 5181 5182 +1
========================================
Hits 309 309
- Misses 4848 4849 +1
Partials 24 24 ☔ View full report in Codecov by Sentry. |
streamer45
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Looks like MySQL needs a special no-op mapper function in order to correctly translate columns into struct fields.
I wish we could add a test for this but we need some work to make proper integrations tests that run against both db engines. I'll take care of it though.
For now I manually tested this on both db drivers and it's looking good.
Ticket Link
https://mattermost.atlassian.net/browse/MM-56178