Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve switch call modal #6

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Improve switch call modal #6

merged 1 commit into from
Feb 4, 2022

Conversation

streamer45
Copy link
Collaborator

Summary

PR fixes a couple of issues with the Switch Call modal which wasn't displaying properly with calls in DMs/GMs due to the missing display name. I also changed the modal's styling to adhere to our product guidelines. Please let me know if I missed anything.

Screenshots

image

image

image

@streamer45 streamer45 added the 1: UX Review Requires review by ux label Feb 3, 2022
@streamer45 streamer45 self-assigned this Feb 3, 2022
Copy link

@abhijit-singh abhijit-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @streamer45, looks great!

@abhijit-singh abhijit-singh removed the 1: UX Review Requires review by ux label Feb 4, 2022
@streamer45 streamer45 merged commit 05dbf54 into main Feb 4, 2022
@streamer45 streamer45 deleted the switch-modal branch February 4, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants